Disable APPROVE button if user is already approved #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Should we also disable the REJECT button when the user is already rejected? oh i see you've already brought that up in #1341
I was actually asking what to do with the REJECT button for approved users (before realizing it should stay enabled), but I hadn't thought of disabling it for rejected users... added in 2d76f2d. |
mvandenburgh
approved these changes
Oct 27, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conditionally disables the approve/reject buttons when a user's status is
APPROVED/REJECTED, respectively.Closes #1341.